It's fine to tell me about his preference for future pull requests, but making me jump through hoops after having reviewed them already... just childish & stubborn 🙄
Notices by muesli (fribbledom@mastodon.social), page 4
-
muesli (fribbledom@mastodon.social)'s status on Monday, 22-Jul-2019 14:03:39 UTC muesli -
muesli (fribbledom@mastodon.social)'s status on Monday, 22-Jul-2019 13:59:13 UTC muesli ...and why is it that by the time I'm back at my machine, I have already forgotten the solution again 😆
-
muesli (fribbledom@mastodon.social)'s status on Monday, 22-Jul-2019 13:53:09 UTC muesli I didn't split them up completely arbitrarily. There was one PR for all typo fixes, one for ineffectual assignments and one for unnecessary conversions. That's rather reasonable imo, and should actually make it a lot easier and less time consuming to review.
-
muesli (fribbledom@mastodon.social)'s status on Monday, 22-Jul-2019 13:47:41 UTC muesli I don't think it comes down to laziness. Clicking "Close" is just as much work as clicking "Merge" 😆
-
muesli (fribbledom@mastodon.social)'s status on Monday, 22-Jul-2019 13:45:57 UTC muesli I'm not really interested in the debate either, I'm merely explaining why I did what I did.
He already reviewed them and it would have been just as much work for him to click "Merge". I would have remembered his preference for the next time and it's all good.
Instead he decides to make me jump through hoops to teach me a lesson. That's just childish.
-
muesli (fribbledom@mastodon.social)'s status on Monday, 22-Jul-2019 13:33:35 UTC muesli That'll teach me! How dare I contribute to his projects! 😂
-
muesli (fribbledom@mastodon.social)'s status on Monday, 22-Jul-2019 13:24:23 UTC muesli Fair enough, but then don't make your contributors jump through hoops if you already did all the review work involved. He could have said "thank you" and "by the way...", and I would have remembered his preference for the next time.
Now I most certainly won't contribute to his projects ever again.
-
muesli (fribbledom@mastodon.social)'s status on Monday, 22-Jul-2019 13:18:32 UTC muesli Of course I'm not posting one pull request per fixed typo.
There was one pull request for all typo fixes in the project, one for ineffectual assignments and one removing unnecessary type conversions.
That's a fairly reasonable partitioning in my eyes.
-
muesli (fribbledom@mastodon.social)'s status on Monday, 22-Jul-2019 12:57:42 UTC muesli Oh my... now he seriously closed all those pull requests. As he mentioned himself, he's aware they're all reasonable (so he already did all the review work involved), and it would have been just as much work for him to actually click "Merge" as it was to click "Close".
What is he trying to do here? Teach me a lesson? That's just silly and stubborn now. The exact opposite of what I'm looking for in open-source maintainership 🙄
-
muesli (fribbledom@mastodon.social)'s status on Monday, 22-Jul-2019 12:52:34 UTC muesli Yeah, that's pretty much my reasoning as well.
-
muesli (fribbledom@mastodon.social)'s status on Monday, 22-Jul-2019 12:31:21 UTC muesli Nobody said maintaining projects is easy 😆
I'm certainly not gonna start lumping typo fixes together with improved error handling. That's just silly and really bad practice.
-
muesli (fribbledom@mastodon.social)'s status on Monday, 22-Jul-2019 12:29:05 UTC muesli You do realize I'm maintaining a wide variety of open source projects since almost 20 years now? 😂
-
muesli (fribbledom@mastodon.social)'s status on Monday, 22-Jul-2019 12:21:41 UTC muesli Heh, yeah, please no drama on GitHub 😂 I don't mean to bash him here either, I'm just seriously a bit baffled.
-
muesli (fribbledom@mastodon.social)'s status on Monday, 22-Jul-2019 12:21:22 UTC muesli Heh, yeah, please no drama on GitHub 😂 I don't mean to bash him either, I'm just seriously a bit baffled.
-
muesli (fribbledom@mastodon.social)'s status on Monday, 22-Jul-2019 12:17:25 UTC muesli I highly respect Andrew (BurntSushi), all of his work and awesome projects, but I really don't know how I'm supposed to feel about that kind of attitude towards project management:
-
muesli (fribbledom@mastodon.social)'s status on Sunday, 21-Jul-2019 21:23:03 UTC muesli Ah, verstehe! 😊
-
muesli (fribbledom@mastodon.social)'s status on Sunday, 21-Jul-2019 21:18:25 UTC muesli s/14/54 ?
-
muesli (fribbledom@mastodon.social)'s status on Sunday, 21-Jul-2019 21:16:50 UTC muesli The city's current estimate is that one third of cars will be electric by then, but only the wealthier people will be able to afford them by then.
-
muesli (fribbledom@mastodon.social)'s status on Sunday, 21-Jul-2019 20:49:20 UTC muesli Hah, maybe 😆
-
muesli (fribbledom@mastodon.social)'s status on Sunday, 21-Jul-2019 20:48:44 UTC muesli Brussels is actually in Belgium 😆